Add a Dockerfile that allows efficient local builds #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been using this Dockerfile for local builds, might as well make it available. It's mostly based on the github workflow in this repository. |
The Dockerfile essentially builds a docker image by downloading moergo-sc/zmk and the current main branch of moergo-sc/glove80-zmk-config, and then building the latter to warm up the image's nix store. When running the image, very little gets downloaded, and the image just builds glove80.uf2 and copies it back to the current directory. The provided `build.sh` script both builds and runs the docker image, calling docker with the appropriate arguments.
|
I've made some changes to make sure that builds don't end up using an old version of the firmware 'trapped' in the docker container, and to allow specifying a specific branch or tag to build against. Do these look good to you? |
|
Looks good to me - tbh I'm interested in being able to do this, I have no attachment to my particular implementation TIL Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile essentially builds a docker image by downloading moergo-sc/zmk and the current main branch of
moergo-sc/glove80-zmk-config, and then building the latter to warm up the image's nix store.
When running the image, very little gets downloaded, and the image just builds glove80.uf2 and copies it back to the current directory.
The provided
build.shscript both builds and runs the docker image, calling docker with the appropriate arguments.